Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tidb-dashboard to v2023.08.15.1 #6967

Merged
merged 1 commit into from
Aug 18, 2023
Merged

chore: update tidb-dashboard to v2023.08.15.1 #6967

merged 1 commit into from
Aug 18, 2023
+6 −6

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Aug 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6966

What is changed and how does it work?

1. This PR fixed the statements list export failed issue
2. This PR support config the ngm component timeout param

Release note

None.

Test

make pd-server
tiup playground v6.5.3 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

@baurine
chore: update tidb-dashboard to v2023.08.15.1
89dae36 
Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 17, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Aug 17, 2023
@ti-chi-bot ti-chi-bot bot requested review from nolouch and Yisaer August 17, 2023 07:41
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2023
@baurine
Copy link
Contributor Author

baurine commented Aug 17, 2023

This PR needs to be cherry-pick to PD 7.1 and 6.1 as well.

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (241ca13) 75.58% compared to head (89dae36) 75.47%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.5    #6967      +/-   ##
===============================================
- Coverage        75.58%   75.47%   -0.12%     
===============================================
  Files              329      329              
  Lines            33595    33595              
===============================================
- Hits             25394    25357      -37     
- Misses            6032     6054      +22     
- Partials          2169     2184      +15
Flag Coverage Δ
unittests 75.47% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CabinfeverB
Copy link
Member

ok-to-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 17, 2023
@HuSharp
Copy link
Member

HuSharp commented Aug 17, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2023
@HuSharp
Copy link
Member

HuSharp commented Aug 17, 2023

@baurine can u paste a picture for running this pr?

@baurine
Copy link
Contributor Author

baurine commented Aug 17, 2023 •
edited
Loading

@baurine can u paste a picture for running this pr?

ok, sure, let me update it soon.

done! updated the PR description, attached a screenshot.

@CabinfeverB
Copy link
Member

/test build

@CabinfeverB
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 89dae36

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4441cd8 into tikv:release-6.5 Aug 18, 2023
18 checks passed
@baurine baurine deleted the chore/update-dashboard branch August 18, 2023 02:25
@baurine
Copy link
Contributor Author

baurine commented Aug 29, 2023

Please help cherry-pick this PR to release-7.1 and release-6.1 branch, thanks~

@baurine
Copy link
Contributor Author

baurine commented Aug 29, 2023

/cherry-pick release-7.1

@baurine
Copy link
Contributor Author

baurine commented Aug 29, 2023

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-7.1: #6997.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2023
@baurine @ti-chi-bot
This is an automated cherry-pick of tikv#6967
a1c1b5a 
close tikv#6966

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-6.1: #6998.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2023
@baurine @ti-chi-bot
This is an automated cherry-pick of tikv#6967
691ff9a 
close tikv#6966

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@HuSharp HuSharp HuSharp approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baurine @CabinfeverB @HuSharp @ti-chi-bot